Proper fixup for " when generating CQL query #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replaceAll for looking back whether the " was escaped did not work as the preceding backslash could have been the result of escaping a backslash itself. A follow up for #5
jakub-id
reviewed
Feb 3, 2026
|
|
||
| static String maybeQuote(String str) { | ||
| if (str == null) | ||
| if (str == null) { |
Contributor
There was a problem hiding this comment.
@adamdickmeiss this function name is confusing since it both quotes and escapes. Btw, we should do the same in cql-go.
Contributor
Author
There was a problem hiding this comment.
Agree, the function name is bad.
There will never be a bare " as the result of a query in the current form. But it did happen in latest release until #5. This is just extra precaution to ensure that if it is bare, it will be escaped. That's all.
jakub-id
reviewed
Feb 3, 2026
| if (ch == '"' && !escaped) { | ||
| sb.append('\\'); | ||
| } | ||
| escaped = ch == '\\' && !escaped; |
Contributor
There was a problem hiding this comment.
@adamdickmeiss what if \ is on the last position like in x\
Contributor
Author
There was a problem hiding this comment.
It will be left as is.
Contributor
There was a problem hiding this comment.
But the resulting query will be invalid no?
jakub-id
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replaceAll for looking back whether the " was escaped did not work as the preceding backslash could have been the result of escaping a backslash itself.
A follow up for #5